From ca85524f91be8877dce6ddb69c83153c9f6b1fed Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Tue, 30 May 2023 16:28:47 +0530 Subject: [PATCH] fix: skip form tours on mobile (#21180) [skip ci] --- .../public/js/onboarding_tours/onboarding_tours.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/frappe/public/js/onboarding_tours/onboarding_tours.js b/frappe/public/js/onboarding_tours/onboarding_tours.js index 63215d3659..df3e3c3894 100644 --- a/frappe/public/js/onboarding_tours/onboarding_tours.js +++ b/frappe/public/js/onboarding_tours/onboarding_tours.js @@ -248,6 +248,10 @@ frappe.ui.OnboardingTour = class OnboardingTour { }; frappe.ui.init_onboarding_tour = () => { + // As of now Tours are only for desktop as it is annoying on mobile. + // Also lot of elements are hidden on mobile so until we find a better way to do it. + if (!window.matchMedia("(min-device-width: 992px)").matches) return; + typeof frappe.boot.onboarding_tours == "undefined" && frappe.boot.onboarding_tours == []; typeof frappe.boot.user.onboarding_status == "undefined" && frappe.boot.user.onboarding_status == {}; @@ -337,9 +341,7 @@ frappe.ui.init_onboarding_tour = () => { } }, 100); }; -// As of now Tours are only for desktop as it is annoying on mobile. -// Also lot of elements are hidden on mobile so until we find a better way to do it. -window.matchMedia("(min-device-width: 992px)").matches && - frappe.router.on("change", () => { - frappe.ui.init_onboarding_tour(); - }); + +frappe.router.on("change", () => { + frappe.ui.init_onboarding_tour(); +});