From ca95b591ae8581a48dfc28f3560670da36f8da0e Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 26 Jun 2023 17:36:53 +0530 Subject: [PATCH] refactor: Pass redis connection directly --- frappe/utils/background_jobs.py | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/frappe/utils/background_jobs.py b/frappe/utils/background_jobs.py index 6b0249e720..b2a3fbab24 100755 --- a/frappe/utils/background_jobs.py +++ b/frappe/utils/background_jobs.py @@ -9,7 +9,7 @@ from uuid import uuid4 import redis from redis.exceptions import BusyLoadingError, ConnectionError -from rq import Connection, Queue, Worker +from rq import Queue, Worker from rq.exceptions import NoSuchJobError from rq.job import Job, JobStatus from rq.logutils import setup_loghandlers @@ -253,17 +253,16 @@ def start_worker( WorkerKlass = DEQUEUE_STRATEGIES.get(strategy, Worker) - with Connection(redis_connection): - logging_level = "INFO" - if quiet: - logging_level = "WARNING" - worker = WorkerKlass(queues, name=get_worker_name(queue_name)) - worker.work( - logging_level=logging_level, - burst=burst, - date_format="%Y-%m-%d %H:%M:%S", - log_format="%(asctime)s,%(msecs)03d %(message)s", - ) + logging_level = "INFO" + if quiet: + logging_level = "WARNING" + worker = WorkerKlass(queues, name=get_worker_name(queue_name), connection=redis_connection) + worker.work( + logging_level=logging_level, + burst=burst, + date_format="%Y-%m-%d %H:%M:%S", + log_format="%(asctime)s,%(msecs)03d %(message)s", + ) def get_worker_name(queue):