vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #27398 from Sajith-K-Sasi/develop

Browse source 
feat: enable bulk edit for doctype with workflow
This commit is contained in:
Akhil Narang 2024-10-22 15:57:51 +05:30 • committed by GitHub
commit cab0b2e484
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frappe/desk/doctype/list_view_settings/list_view_settings.json
View file

@ -10,6 +10,7 @@
"disable_comment_count",
"disable_sidebar_stats",
"disable_auto_refresh",
"allow_edit",
"total_fields",
"fields_html",
"fields"
@ -56,10 +57,17 @@
"fieldname": "disable_comment_count",
"fieldtype": "Check",
"label": "Disable Comment Count"
},
{
"default": "0",
"description": "Allow editing even if the doctype has a workflow set up.\n\nDoes nothing if a workflow isn't set up.",
"fieldname": "allow_edit",
"fieldtype": "Check",
"label": "Allow Bulk Editing"
}
],
"links": [],
"modified": "2024-03-23 16:03:29.188038",
"modified": "2024-08-21 18:17:24.889783",
"modified_by": "Administrator",
"module": "Desk",
"name": "List View Settings",

1
frappe/desk/doctype/list_view_settings/list_view_settings.py
View file

@ -14,6 +14,7 @@ class ListViewSettings(Document):
if TYPE_CHECKING:
from frappe.types import DF
allow_edit: DF.Check
disable_auto_refresh: DF.Check
disable_comment_count: DF.Check
disable_count: DF.Check

10
frappe/public/js/frappe/list/list_view.js
View file

@ -1895,6 +1895,14 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
return frappe.perm.has_perm(doctype, 0, "submit");
};
const is_bulk_edit_allowed = (doctype) => {
// Check settings if there is a workflow defined, otherwise directly allow
if (frappe.model.has_workflow(doctype)) {
return !!this.list_view_settings?.allow_edit;
}
return true;
};
// utility
const bulk_assignment = () => {
return {
@ -2094,7 +2102,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
};
// bulk edit
if (has_editable_fields(doctype) && !frappe.model.has_workflow(doctype)) {
if (has_editable_fields(doctype) && is_bulk_edit_allowed(doctype)) {
actions_menu_items.push(bulk_edit());
}