vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(minor): Unpublish article when category is unpublished #15361

Browse source
This commit is contained in:
Rushabh Mehta 2024-01-08 11:39:02 +05:30
parent f7ff072b5a
commit cb2e803d0c
2 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
frappe/website/doctype/help_article/test_help_article.py
View file

@ -39,6 +39,18 @@ class TestHelpArticle(FrappeTestCase):
self.assertEqual(self.help_article.helpful, 1)
self.assertEqual(self.help_article.not_helpful, 1)
def test_category_disable(self):
self.help_article.load_from_db()
self.help_article.published = 1
self.help_article.save()
self.help_category.load_from_db()
self.help_category.published = 0
self.help_category.save()
self.help_article.load_from_db()
self.assertEqual(self.help_article.published, 0)
@classmethod
def tearDownClass(cls) -> None:
frappe.delete_doc(cls.help_article.doctype, cls.help_article.name)

5
frappe/website/doctype/help_category/help_category.py
View file

@ -32,6 +32,11 @@ class HelpCategory(WebsiteGenerator):
def validate(self):
self.set_route()
# disable help articles of this category
if not self.published:
for d in frappe.get_all("Help Article", dict(category=self.name)):
frappe.db.set_value("Help Article", d.name, "published", 0)
def set_route(self):
if not self.route:
self.route = "kb/" + self.scrub(self.category_name)