diff --git a/frappe/public/js/frappe/ui/dialog.js b/frappe/public/js/frappe/ui/dialog.js index b2ac9a7769..515b693482 100644 --- a/frappe/public/js/frappe/ui/dialog.js +++ b/frappe/public/js/frappe/ui/dialog.js @@ -180,11 +180,9 @@ frappe.ui.Dialog = class Dialog extends frappe.ui.FieldGroup { this.footer.removeClass("hide"); this.has_primary_action = true; var me = this; - return this.get_primary_btn() - .removeClass("hide") - .html(label) - .off("click") - .on("click", function () { + const primary_btn = this.get_primary_btn().removeClass("hide").html(label); + if (typeof click == "function") { + primary_btn.off("click").on("click", function () { me.primary_action_fulfilled = true; // get values and send it // as first parameter to click callback @@ -193,6 +191,8 @@ frappe.ui.Dialog = class Dialog extends frappe.ui.FieldGroup { if (!values) return; click && click.apply(me, [values]); }); + } + return primary_btn; } set_secondary_action(click) {