From cb66e6508d92be0d20cf20d3b932cc8fefea8858 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Fri, 22 Oct 2021 14:17:52 +0530 Subject: [PATCH] refactor(minor): Use pluck & better var naming --- frappe/permissions.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/permissions.py b/frappe/permissions.py index 0585b1e220..e21cec982e 100644 --- a/frappe/permissions.py +++ b/frappe/permissions.py @@ -353,10 +353,10 @@ def get_roles(user=None, with_standard=True): return frappe.get_all("Role", pluck="name") # return all available roles else: table = DocType("Has Role") - result = frappe.qb.from_(table).where( + roles = frappe.qb.from_(table).where( (table.parent == user) & (table.role.notin(["All", "Guest"])) - ).select(table.role).run() - return [r[0] for r in result] + ['All', 'Guest'] + ).select(table.role).run(pluck=True) + return roles + ['All', 'Guest'] roles = frappe.cache().hget("roles", user, get)