From cba0050db829bae4aab0f495f07fdfffbabb5089 Mon Sep 17 00:00:00 2001 From: Abhishek Balam Date: Wed, 30 Sep 2020 03:52:21 +0530 Subject: [PATCH] fix: s3 sucess email sent even when checkbox not selected --- frappe/integrations/offsite_backup_utils.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/frappe/integrations/offsite_backup_utils.py b/frappe/integrations/offsite_backup_utils.py index 7d33dd14bc..e78ab6da19 100644 --- a/frappe/integrations/offsite_backup_utils.py +++ b/frappe/integrations/offsite_backup_utils.py @@ -19,7 +19,7 @@ def send_email(success, service_name, doctype, email_field, error_status=None): return if success: - if not frappe.db.get_value(doctype, None, "send_email_for_successful_backup"): + if not int(frappe.db.get_value(doctype, None, "send_email_for_successful_backup")): return subject = "Backup Upload Successful" @@ -28,7 +28,6 @@ def send_email(success, service_name, doctype, email_field, error_status=None):

Hi there, this is just to inform you that your backup was successfully uploaded to your {0} bucket. So relax!

""".format( service_name ) - else: subject = "[Warning] Backup Upload Failed" message = """