From cbb39d463a7e14bcf92082dbc9594ac4c32d3893 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 1 Jan 2025 14:29:36 +0530 Subject: [PATCH] perf: Don't query redirects on existing session This is only used for a new user. After that it's never used but still present in EVERY request! https://ankush.dev/p/flamegraph-missing-forest-for-trees towards https://github.com/frappe/caffeine/issues/15 --- frappe/auth.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/frappe/auth.py b/frappe/auth.py index d254aa1b1e..d7bfce08a9 100644 --- a/frappe/auth.py +++ b/frappe/auth.py @@ -205,8 +205,7 @@ class LoginManager: frappe.response["full_name"] = self.full_name # redirect information - redirect_to = frappe.cache.hget("redirect_after_login", self.user) - if redirect_to: + if not resume and (redirect_to := frappe.cache.hget("redirect_after_login", self.user)): frappe.local.response["redirect_to"] = redirect_to frappe.cache.hdel("redirect_after_login", self.user)