From cc43af984ed82976a681641cdad96e309af66976 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sat, 24 Jun 2023 16:05:45 +0530 Subject: [PATCH] fix: Only import LDAP if it's enabled This is disabled on 99%+ sites, still incurs 3-4MB of memory hit on import of ldap3. --- frappe/www/login.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/frappe/www/login.py b/frappe/www/login.py index 0aa1eba0cd..7cf89e7c3c 100644 --- a/frappe/www/login.py +++ b/frappe/www/login.py @@ -5,7 +5,6 @@ import frappe import frappe.utils from frappe import _ from frappe.auth import LoginManager -from frappe.integrations.doctype.ldap_settings.ldap_settings import LDAPSettings from frappe.rate_limiter import rate_limit from frappe.utils import cint, get_url from frappe.utils.data import escape_html @@ -85,7 +84,10 @@ def get_context(context): ) context["social_login"] = True - context["ldap_settings"] = LDAPSettings.get_ldap_client_settings() + if cint(frappe.db.get_value("LDAP Settings", "LDAP Settings", "enabled")): + from frappe.integrations.doctype.ldap_settings.ldap_settings import LDAPSettings + + context["ldap_settings"] = LDAPSettings.get_ldap_client_settings() login_label = [_("Email")]