Merge pull request #1642 from rmehta/close-dialog-on-enter

[minor] [enhancement] submit confirm dialog on enter, fixes frappe/erpnext#4996

frappe/core/page/data_import_tool/importer.py

@@ -114,7 +114,7 @@ def upload(rows = None, submit_after_import=None, ignore_encoding_errors=False,
 									d[fieldname] = getdate(parse_date(d[fieldname])) if d[fieldname] else None
 								elif fieldtype == "Datetime":
 									if d[fieldname]:
-										_date, _time = d[fieldname].split(" ")
+										_date, _time = d[fieldname].split()
 										_date = parse_date(d[fieldname])
 										d[fieldname] = get_datetime(_date + " " + _time)
 									else:

frappe/public/js/frappe/desk.js

@@ -260,12 +260,24 @@ frappe.Application = Class.extend({
 				return false;
 			})
 			.keydown("esc", function(e) {
+				// close open grid row
 				var open_row = $(".grid-row-open");
 				if(open_row.length) {
 					var grid_row = open_row.data("grid_row");
 					grid_row.toggle_view(false);
+					return false;
+				}
+
+				// close open dialog
+				if(cur_dialog && !cur_dialog.no_cancel_flag) {
+					cur_dialog.cancel();
+					return false;
+				}
+			})
+			.keydown("return", function() {
+				if(cur_dialog && cur_dialog.confirm_dialog) {
+					cur_dialog.get_primary_btn().trigger('click');
 				}
-				return false;
 			})
 			.keydown("ctrl+down meta+down", function(e) {
 				var open_row = $(".grid-row-open");

frappe/public/js/frappe/ui/dialog.js

@@ -114,9 +114,3 @@ frappe.ui.Dialog = frappe.ui.FieldGroup.extend({
 	}
 });
 
-// close open dialogs on ESC
-$(document).bind('keydown', function(e) {
-	if(cur_dialog && !cur_dialog.no_cancel_flag && e.which==27) {
-		cur_dialog.cancel();
-	}
-});

frappe/public/js/frappe/ui/messages.js

@@ -26,13 +26,16 @@ frappe.confirm = function(message, ifyes, ifno) {
 		],
 		primary_action_label: __("Yes"),
 		primary_action: function() {
-			ifyes();
+			if(ifyes) ifyes();
 			d.hide();
 		},
 		secondary_action_label: __("No")
 	});
 	d.show();
 
+	// flag, used to bind "okay" on enter
+	d.confirm_dialog = true;
+
 	// no if closed without primary action
 	if(ifno) {
 		d.onhide = function() {