From cd9f9ab473b6bfc6ad2f8fafa8a94aa0c0612b86 Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Tue, 19 Mar 2024 19:17:16 +0100 Subject: [PATCH] refactor: get_like_html --- frappe/public/js/frappe/list/list_view.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js index 2506c9e724..21814d2383 100644 --- a/frappe/public/js/frappe/list/list_view.js +++ b/frappe/public/js/frappe/list/list_view.js @@ -1012,15 +1012,14 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList { } get_like_html(doc) { - const ef = this._element_factory; const liked_by = doc._liked_by ? JSON.parse(doc._liked_by) : []; const is_liked = liked_by.includes(frappe.session.user); const title = liked_by.map((u) => frappe.user_info(u).fullname).join(", "); const div = document.createElement("div"); - const like = ef.get_like_element(doc.name, is_liked, liked_by, title); - - div.appendChild(like); + div.appendChild( + this._element_factory.get_like_element(doc.name, is_liked, liked_by, title) + ); return div.innerHTML; }