From cdb943d49ae10d55cffd900f3eb5d0effc7ccbe1 Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Mon, 17 Apr 2023 12:03:43 +0530 Subject: [PATCH] fix: Show background jobs only to permitted users --- frappe/public/js/frappe/model/perm.js | 4 +--- frappe/public/js/frappe/ui/toolbar/toolbar.js | 8 +++++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/frappe/public/js/frappe/model/perm.js b/frappe/public/js/frappe/model/perm.js index 8ed7d6b028..948a31b1fc 100644 --- a/frappe/public/js/frappe/model/perm.js +++ b/frappe/public/js/frappe/model/perm.js @@ -34,9 +34,7 @@ $.extend(frappe.perm, { doctype_perm: {}, - has_perm: (doctype, permlevel, ptype, doc) => { - if (!permlevel) permlevel = 0; - + has_perm: (doctype, permlevel = 0, ptype = "read", doc) => { const perms = frappe.perm.get_perm(doctype, doc); return !!perms?.[permlevel]?.[ptype]; }, diff --git a/frappe/public/js/frappe/ui/toolbar/toolbar.js b/frappe/public/js/frappe/ui/toolbar/toolbar.js index 6a2dac588c..bef0c19b4e 100644 --- a/frappe/public/js/frappe/ui/toolbar/toolbar.js +++ b/frappe/public/js/frappe/ui/toolbar/toolbar.js @@ -137,9 +137,11 @@ frappe.ui.toolbar.Toolbar = class { __("Generate Tracking URL") ); - frappe.search.utils.make_function_searchable(function () { - frappe.set_route("List", "RQ Job"); - }, __("Background Jobs")); + if (frappe.perm.has_perm("RQ Job")) { + frappe.search.utils.make_function_searchable(function () { + frappe.set_route("List", "RQ Job"); + }, __("Background Jobs")); + } } }