From cfc8d7a010a4b678be40714ca8cb7c4071f36a2a Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Thu, 22 Aug 2024 15:25:42 +0530 Subject: [PATCH] fix(print_utils): simplify checks Make it more readable, and prevent error Sentry FRAPPE-4SQ ``` TypeError: Cannot read properties of undefined (reading 'default_letter_head') at frappe.ui.get_print_settings(../../../../../apps/frappe/frappe/public/js/frappe/form/print_utils.js:6:65) at items.action(../../../../../apps/frappe/frappe/public/js/frappe/views/reports/query_report.js:1640:29) at $link(../../../../../apps/frappe/frappe/public/js/frappe/ui/page.js:506:11) at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27) at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28) at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)``` Signed-off-by: Akhil Narang --- frappe/public/js/frappe/form/print_utils.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/frappe/form/print_utils.js b/frappe/public/js/frappe/form/print_utils.js index 92e0b46e69..4b5bc3257c 100644 --- a/frappe/public/js/frappe/form/print_utils.js +++ b/frappe/public/js/frappe/form/print_utils.js @@ -1,10 +1,12 @@ frappe.ui.get_print_settings = function (pdf, callback, letter_head, pick_columns) { var print_settings = locals[":Print Settings"]["Print Settings"]; - var default_letter_head = - locals[":Company"] && frappe.defaults.get_default("company") - ? locals[":Company"][frappe.defaults.get_default("company")]["default_letter_head"] - : ""; + var company = frappe.defaults.get_default("company"); + var default_letter_head = ""; + + if (locals[":Company"] && locals[":Company"][company]) { + default_letter_head = locals[":Company"][company]["default_letter_head"] || ""; + } var columns = [ {