vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor: PUT == PATCH

Browse source 
Correct conventions for partial updates
This commit is contained in:
Ankush Menat 2023-09-05 18:31:00 +05:30
parent c8cd658d26
commit cfd3fb9341
2 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frappe/api/v2.py
View file

@ -169,7 +169,7 @@ url_rules = [
Rule("/document/<doctype>", methods=["GET"], endpoint=document_list),
Rule("/document/<doctype>", methods=["POST"], endpoint=create_doc),
Rule("/document/<doctype>/<path:name>/", methods=["GET"], endpoint=read_doc),
Rule("/document/<doctype>/<path:name>/", methods=["PUT"], endpoint=update_doc),
Rule("/document/<doctype>/<path:name>/", methods=["PATCH", "PUT"], endpoint=update_doc),
Rule("/document/<doctype>/<path:name>/", methods=["DELETE"], endpoint=delete_doc),
Rule(
"/document/<doctype>/<path:name>/method/<method>/",

19
frappe/tests/test_api.py
View file

@ -135,6 +135,9 @@ class FrappeAPITestCase(FrappeTestCase):
def put(self, path, data, **kwargs) -> TestResponse:
return make_request(target=self.TEST_CLIENT.put, args=(path,), kwargs={"json": data, **kwargs})
def patch(self, path, data, **kwargs) -> TestResponse:
return make_request(target=self.TEST_CLIENT.patch, args=(path,), kwargs={"json": data, **kwargs})
def delete(self, path, **kwargs) -> TestResponse:
return make_request(target=self.TEST_CLIENT.delete, args=(path,), kwargs=kwargs)
@ -222,7 +225,7 @@ class TestResourceAPI(FrappeAPITestCase):
self.assertIsInstance(docname, str)
self.GENERATED_DOCUMENTS.append(docname)
@parameterize("", "v1", "v2")
@parameterize("", "v1")
def test_update_document(self):
generated_desc = frappe.mock("paragraph")
data = {"description": generated_desc, "sid": self.sid}
@ -313,7 +316,7 @@ class TestMethodAPIV1(FrappeAPITestCase):
self.assertEqual(response.status_code, 404)
class TestResourceAPIV2(FrappeAPITestCase):
class TestResourceAPIV2(TestResourceAPI):
version = "v2"
def setUp(self) -> None:
@ -324,6 +327,18 @@ class TestResourceAPIV2(FrappeAPITestCase):
response = self.get(self.resource_path("Website Theme", "Standard", "method", "get_apps"))
self.assertEqual(response.json["data"][0]["name"], "frappe")
def test_update_document(self):
generated_desc = frappe.mock("paragraph")
data = {"description": generated_desc, "sid": self.sid}
random_doc = choice(self.GENERATED_DOCUMENTS)
response = self.patch(self.resource_path(self.DOCTYPE, random_doc), data=data)
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json["data"]["description"], generated_desc)
response = self.get(self.resource_path(self.DOCTYPE, random_doc))
self.assertEqual(response.json["data"]["description"], generated_desc)
class TestMethodAPIV2(FrappeAPITestCase):
version = "v2"