From d06a5808cc2241a7198e8234307745e9e33ffa16 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Mon, 16 Oct 2023 18:08:00 +0530 Subject: [PATCH] fix: validation permission on `tag` creation (#22753) * fix: validation permission on `tag` creation * refactor: apply checks on all operations Add/remove both are controlled by update --------- Co-authored-by: Ankush Menat --- frappe/desk/doctype/tag/tag.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/frappe/desk/doctype/tag/tag.py b/frappe/desk/doctype/tag/tag.py index 05adaed926..8ee18fa74b 100644 --- a/frappe/desk/doctype/tag/tag.py +++ b/frappe/desk/doctype/tag/tag.py @@ -48,8 +48,6 @@ def add_tags(tags, dt, docs, color=None): for tag in tags: DocTags(dt).add(doc, tag) - # return tag - @frappe.whitelist() def remove_tag(tag, dt, dn): @@ -153,6 +151,7 @@ def update_tags(doc, tags): :param doc: Document to be added to global tags """ + doc.check_permission("write") new_tags = {tag.strip() for tag in tags.split(",") if tag} existing_tags = [ tag.tag