refactor: move histfile setting into helper function

This will ensure even users of `bench db-console` can use it

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2024-03-14 11:09:50 +05:30
parent afdb455b5a
commit d0923b0cd9
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F

View file

@ -497,12 +497,9 @@ def mariadb(context, extra_args):
"""
Enter into mariadb console for a given site.
"""
from frappe.utils import get_site_path
site = get_site(context)
frappe.init(site=site)
frappe.conf.db_type = "mariadb"
os.environ["MYSQL_HISTFILE"] = os.path.abspath(get_site_path("logs", "mariadb_console.log"))
_enter_console(extra_args=extra_args)
@ -513,17 +510,20 @@ def postgres(context, extra_args):
"""
Enter into postgres console for a given site.
"""
from frappe.utils import get_site_path
site = get_site(context)
frappe.init(site=site)
frappe.conf.db_type = "postgres"
os.environ["PSQL_HISTORY"] = os.path.abspath(get_site_path("logs", "postgresql_console.log"))
_enter_console(extra_args=extra_args)
def _enter_console(extra_args=None):
from frappe.database import get_command
from frappe.utils import get_site_path
if frappe.conf.db_type == "mariadb":
os.environ["MYSQL_HISTFILE"] = os.path.abspath(get_site_path("logs", "mariadb_console.log"))
else:
os.environ["PSQL_HISTORY"] = os.path.abspath(get_site_path("logs", "postgresql_console.log"))
bin, args, bin_name = get_command(
host=frappe.conf.db_host,