vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: has_content check for fieldtype TextEditor

Browse source 
When a TextEditor field contains only an image, while checking for
content, HTML tags are stripped off including the only image.
This change adds a loose but explicit check for img tag.
This commit is contained in:
Faris Ansari 2022-08-17 14:40:40 +05:30
parent 4c60aec7df
commit d11692c52f
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frappe/model/base_document.py
View file

@ -671,10 +671,19 @@ class BaseDocument:
return _("Error: Value missing for {0}: {1}").format(_(df.parent), _(df.label))
def has_content(df):
value = cstr(self.get(df.fieldname))
has_text_content = strip_html(value).strip()
has_img_tag = "<img" in value
if df.fieldtype == "Text Editor" and (has_text_content or has_img_tag):
return True
else:
return has_text_content
missing = []
for df in self.meta.get("fields", {"reqd": ("=", 1)}):
if self.get(df.fieldname) in (None, []) or not strip_html(cstr(self.get(df.fieldname))).strip():
if self.get(df.fieldname) in (None, []) or not has_content(df):
missing.append((df.fieldname, get_msg(df)))
# check for missing parent and parenttype