vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: ignore perm while updating notification settings

Browse source 
If you can update user, do you should be able to update notif settings.
This commit is contained in:
Ankush Menat 2023-10-25 11:22:05 +05:30
parent 65e859c938
commit d196dfeac4
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frappe/core/doctype/user/user.py
View file

@ -248,7 +248,7 @@ class User(Document):
frappe.local.login_manager.logout(user=self.name)
# toggle notifications based on the user's status
toggle_notifications(self.name, enable=cint(self.enabled))
toggle_notifications(self.name, enable=cint(self.enabled), ignore_permissions=True)
def add_system_manager_role(self):
if self.is_system_manager_disabled():

4
frappe/desk/doctype/notification_settings/notification_settings.py
View file

@ -70,7 +70,7 @@ def create_notification_settings(user):
_doc.insert(ignore_permissions=True)
def toggle_notifications(user: str, enable: bool = False):
def toggle_notifications(user: str, enable: bool = False, ignore_permissions=False):
try:
settings = frappe.get_doc("Notification Settings", user)
except frappe.DoesNotExistError:
@ -79,7 +79,7 @@ def toggle_notifications(user: str, enable: bool = False):
if settings.enabled != enable:
settings.enabled = enable
settings.save()
settings.save(ignore_permissions=ignore_permissions)
@frappe.whitelist()