From d00b20a610b9d04ddefb9ab5eb8c406c7fa0e6d3 Mon Sep 17 00:00:00 2001 From: Achilles Rasquinha Date: Wed, 21 Mar 2018 12:37:04 +0530 Subject: [PATCH 1/2] user image fix --- frappe/core/doctype/user/user.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/frappe/core/doctype/user/user.py b/frappe/core/doctype/user/user.py index edf4c285b4..69d6cb1628 100644 --- a/frappe/core/doctype/user/user.py +++ b/frappe/core/doctype/user/user.py @@ -68,6 +68,7 @@ class User(Document): self.validate_user_email_inbox() ask_pass_update() self.validate_roles() + self.validate_user_image() if self.language == "Loading...": self.language = None @@ -81,6 +82,10 @@ class User(Document): self.set('roles', []) self.append_roles(*[role.role for role in role_profile.roles]) + def validate_user_image(self): + if len(self.user_image) > 2000: + frappe.throw(_("Not a valid User Image.")) + def on_update(self): # clear new password self.validate_user_limit() From 73aeb5ea96252507721018ae22c47d3c2d2555d9 Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Wed, 21 Mar 2018 15:27:24 +0530 Subject: [PATCH 2/2] fix test --- frappe/core/doctype/user/user.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/core/doctype/user/user.py b/frappe/core/doctype/user/user.py index 69d6cb1628..ab5609a5da 100644 --- a/frappe/core/doctype/user/user.py +++ b/frappe/core/doctype/user/user.py @@ -83,7 +83,7 @@ class User(Document): self.append_roles(*[role.role for role in role_profile.roles]) def validate_user_image(self): - if len(self.user_image) > 2000: + if self.user_image and len(self.user_image) > 2000: frappe.throw(_("Not a valid User Image.")) def on_update(self):