vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: wrap doc index update in try block

Browse source 
failure in index update shouldn't affect document lifecycle
This commit is contained in:
Faris Ansari 2025-07-31 23:02:52 +05:30
parent 7b71c3aeb7
commit d2ca1d63f4
1 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
frappe/search/sqlite_search.py
View file

@ -1384,8 +1384,13 @@ def update_doc_index(doc: Document, method=None):
any_field_changed = any(doc.has_value_changed(field) for field in fields)
if any_field_changed:
print(f"Enqueuing {search.__class__.__name__}.index_doc for {doc.doctype}:{doc.name}")
search.index_doc(doctype, doc.name)
try:
search.index_doc(doctype, doc.name)
except Exception:
frappe.log_error(
title="SQLite Search Index Update Error",
message=f"Failed to update index for {doctype}:{doc.name} in {search.__class__.__name__}",
)
def delete_doc_index(doc: Document, method=None):
@ -1403,8 +1408,14 @@ def delete_doc_index(doc: Document, method=None):
if not fields:
continue
print(f"Enqueuing {search.__class__.__name__}.remove_doc for {doc.doctype}:{doc.name}")
search.remove_doc(doctype, doc.name)
try:
# Remove the document from the index
search.remove_doc(doctype, doc.name)
except Exception:
frappe.log_error(
title="SQLite Search Index Delete Error",
message=f"Failed to remove index for {doctype}:{doc.name} in {search.__class__.__name__}",
)
def get_search_classes() -> list[type[SQLiteSearch]]: