From d2d669b72053de18e8638b54dca0d39a83ab4fa8 Mon Sep 17 00:00:00 2001
From: Ankush Menat <ankush@frappe.io>
Date: Wed, 31 Jan 2024 18:09:20 +0530
Subject: [PATCH] fix: don't notify links if not public

---
 frappe/desk/doctype/note/note.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/frappe/desk/doctype/note/note.py b/frappe/desk/doctype/note/note.py
index 9cc14cbc1e..ef64d17f79 100644
--- a/frappe/desk/doctype/note/note.py
+++ b/frappe/desk/doctype/note/note.py
@@ -28,6 +28,9 @@ class Note(Document):
 			# expire this notification in a week (default)
 			self.expire_notification_on = frappe.utils.add_days(self.creation, 7)
 
+		if not self.public and self.notify_on_login:
+			self.notify_on_login = 0
+
 		if not self.content:
 			self.content = "<span></span>"