From d3349336011f51bcf184af2dbe511ffe8606cb0d Mon Sep 17 00:00:00 2001 From: Saurabh Date: Mon, 4 Mar 2019 16:55:49 +0530 Subject: [PATCH] fix: check if app and category exists in module --- frappe/config/__init__.py | 2 +- frappe/patches/v12_0/init_desk_settings.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/config/__init__.py b/frappe/config/__init__.py index b1307aca96..cbe0b267f4 100644 --- a/frappe/config/__init__.py +++ b/frappe/config/__init__.py @@ -26,7 +26,7 @@ def get_modules_from_all_apps_for_user(user=None): module["onboard_present"] = 1 if home_settings: - category_settings = home_settings[module["category"]] + category_settings = home_settings[module.get("category")] if module.get("category") else {} if module_name not in category_settings: module["hidden"] = 1 else: diff --git a/frappe/patches/v12_0/init_desk_settings.py b/frappe/patches/v12_0/init_desk_settings.py index dff572d774..aa1060b906 100644 --- a/frappe/patches/v12_0/init_desk_settings.py +++ b/frappe/patches/v12_0/init_desk_settings.py @@ -13,6 +13,8 @@ def execute(): settings = {} for module in all_modules: + if not module.get("app"): continue + links = get_onboard_items(module["app"], frappe.scrub(module["module_name"]))[:5] module_settings = { "links": ",".join([d["label"] for d in links])