From 31cef1ac5b176bc40166acf2980a78b7325f2394 Mon Sep 17 00:00:00 2001 From: Himanshu Warekar Date: Wed, 23 Oct 2019 22:26:32 +0530 Subject: [PATCH 1/2] fix: arguments not passed --- frappe/model/rename_doc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/model/rename_doc.py b/frappe/model/rename_doc.py index 9b1bf09c4c..1465ade755 100644 --- a/frappe/model/rename_doc.py +++ b/frappe/model/rename_doc.py @@ -12,7 +12,7 @@ from frappe.model.utils.user_settings import sync_user_settings, update_user_set @frappe.whitelist() -def update_document_title(doctype, docname, title_field, old_title, new_title, old_name, new_name): +def update_document_title(doctype, docname, title_field=None, old_title=None, new_title=None, old_name=None, new_name=None): """ Update title from header in form view """ From 604b659353200d90bba32261d783026a5eb6497e Mon Sep 17 00:00:00 2001 From: Himanshu Warekar Date: Wed, 23 Oct 2019 22:26:45 +0530 Subject: [PATCH 2/2] fix: check for old and new names --- frappe/model/rename_doc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/model/rename_doc.py b/frappe/model/rename_doc.py index 1465ade755..34cacee9aa 100644 --- a/frappe/model/rename_doc.py +++ b/frappe/model/rename_doc.py @@ -16,11 +16,11 @@ def update_document_title(doctype, docname, title_field=None, old_title=None, ne """ Update title from header in form view """ - if new_title and old_title != new_title: + if old_title and new_title and not old_title == new_title: frappe.db.set_value(doctype, docname, title_field, new_title) frappe.msgprint(_('Saved'), alert=True, indicator='green') - if new_name and old_name != new_name: + if old_name and new_name and not old_name == new_name: return rename_doc(doctype, old_name, new_name) return old_name