perf: avoid layout thrashing in grid setup_toolbar (#37265)

This commit is contained in:
Sagar Vora 2026-02-19 22:54:35 +05:30 committed by GitHub
parent ffe362316d
commit d3f090edac
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -593,8 +593,9 @@ export default class Grid {
}
setup_toolbar() {
if (this.is_editable()) {
this.wrapper.find(".grid-footer").toggle(true);
const is_editable = this.is_editable();
if (is_editable) {
this.wrapper.find(".grid-footer").removeClass("hidden");
const num_selected_rows = this.get_selected_children().length;
// show, hide buttons to add rows
@ -619,12 +620,12 @@ export default class Grid {
this.grid_rows.length < this.grid_pagination.page_length &&
!this.df.allow_bulk_edit
) {
this.wrapper.find(".grid-footer").toggle(false);
this.wrapper.find(".grid-footer").addClass("hidden");
}
this.wrapper
.find(".grid-add-row, .grid-add-multiple-rows, .grid-upload")
.toggle(this.is_editable());
.toggleClass("hidden", !is_editable);
}
truncate_rows() {