Merge pull request #13984 from gavindsouza/newsletter-unset-autocommit

fix: Revert auto_commit after frappe.sendmail
This commit is contained in:
gavin 2021-08-20 16:23:48 +05:30 committed by GitHub
commit d3f3df2ce1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -165,6 +165,7 @@ class Newsletter(WebsiteGenerator):
sender = self.send_from or frappe.utils.get_formatted_email(self.owner)
args = {"message": message, "name": self.name}
is_auto_commit_set = bool(frappe.db.auto_commit_on_many_writes)
frappe.db.auto_commit_on_many_writes = not frappe.flags.in_test
frappe.sendmail(
@ -184,7 +185,7 @@ class Newsletter(WebsiteGenerator):
args=args,
)
frappe.db.auto_commit_on_many_writes = not frappe.flags.in_test
frappe.db.auto_commit_on_many_writes = is_auto_commit_set
def get_message(self) -> str:
if self.content_type == "HTML":