From d3ffa75288b598fbbebf3df02dddc1584cb3fa56 Mon Sep 17 00:00:00 2001 From: "DHia' A. SHalabi" Date: Mon, 10 Mar 2025 12:21:15 +0300 Subject: [PATCH] Merge pull request #31602 from dhiashalabi/fix/update-popup-msg-format refactor: Use f-string for version update message formatting --- frappe/utils/change_log.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/frappe/utils/change_log.py b/frappe/utils/change_log.py index f1a6f82dd1..83310567a6 100644 --- a/frappe/utils/change_log.py +++ b/frappe/utils/change_log.py @@ -245,7 +245,6 @@ def check_release_on_github( owner: str, repo: str, current_version: Version ) -> tuple[Version, str] | tuple[None, None]: """Check the latest release for a repo URL on GitHub.""" - import requests if not owner: raise ValueError("Owner cannot be empty") @@ -374,11 +373,7 @@ def show_update_popup(): """ if release_links: message = _("New {} releases for the following apps are available").format(_(update_type)) - update_message += ( - "
{}
".format( - message, release_links - ) - ) + update_message += f"
{message}
" primary_action = None if on_frappecloud():