From d09ee52d13d0055dd7a2df54b0c7c66ac4ec9b77 Mon Sep 17 00:00:00 2001 From: s-aga-r Date: Tue, 10 Sep 2024 22:05:41 +0530 Subject: [PATCH] fix: prevent sending emails to System Manager when email notifications are disabled --- .../personal_data_deletion_request.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/frappe/website/doctype/personal_data_deletion_request/personal_data_deletion_request.py b/frappe/website/doctype/personal_data_deletion_request/personal_data_deletion_request.py index 51f0b36909..4c3ed0354d 100644 --- a/frappe/website/doctype/personal_data_deletion_request/personal_data_deletion_request.py +++ b/frappe/website/doctype/personal_data_deletion_request/personal_data_deletion_request.py @@ -7,6 +7,7 @@ import re import frappe from frappe import _ from frappe.core.utils import find +from frappe.desk.doctype.notification_settings.notification_settings import is_email_notifications_enabled from frappe.model.document import Document from frappe.utils import get_datetime, get_fullname, time_diff_in_hours from frappe.utils.user import get_system_managers @@ -101,10 +102,13 @@ class PersonalDataDeletionRequest(Document): ) def notify_system_managers(self): - system_managers = get_system_managers(only_name=True) + recipients = [] + for manager in get_system_managers(only_name=True): + if is_email_notifications_enabled(manager): + recipients.append(manager) frappe.sendmail( - recipients=system_managers, + recipients=recipients, subject=_("User {0} has requested for data deletion").format(self.email), template="data_deletion_approval", args={"user": self.email, "url": frappe.utils.get_url(self.get_url())},