Merge pull request #27909 from akhilnarang/number-format-currency-option

chore: add in system setting to allow using number format from currency
This commit is contained in:
Akhil Narang 2024-10-08 13:03:08 +05:30 committed by GitHub
commit d453db40ba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 14 additions and 2 deletions

View file

@ -18,6 +18,7 @@
"date_format",
"time_format",
"number_format",
"use_number_format_from_currency",
"first_day_of_the_week",
"column_break_7",
"float_precision",
@ -677,12 +678,18 @@
"fieldname": "rate_limit_email_link_login",
"fieldtype": "Int",
"label": "Rate limit for email link login"
},
{
"default": "0",
"fieldname": "use_number_format_from_currency",
"fieldtype": "Check",
"label": "Use Number Format from Currency"
}
],
"icon": "fa fa-cog",
"issingle": 1,
"links": [],
"modified": "2024-08-20 13:50:49.711427",
"modified": "2024-09-26 16:20:59.417151",
"modified_by": "Administrator",
"module": "Core",
"name": "System Settings",

View file

@ -94,6 +94,7 @@ class SystemSettings(Document):
time_format: DF.Literal["HH:mm:ss", "HH:mm"]
time_zone: DF.Literal[None]
two_factor_method: DF.Literal["OTP App", "SMS", "Email"]
use_number_format_from_currency: DF.Check
welcome_email_template: DF.Link | None
# end: auto-generated types

View file

@ -177,8 +177,12 @@ function get_currency_symbol(currency) {
}
function get_number_format(currency) {
let sysdefaults = frappe?.boot?.sysdefaults;
return (
(frappe.boot && frappe.boot.sysdefaults && frappe.boot.sysdefaults.number_format) ||
(sysdefaults.use_number_format_from_currency &&
currency &&
frappe.model.get_value(":Currency", currency, "number_format")) ||
sysdefaults.number_format ||
"#,###.##"
);
}