From d4ba2c51e4e5e7835b43aa674f44ab0793acf65c Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Mon, 7 Nov 2022 20:48:05 +0530 Subject: [PATCH] fix: hide/make read_only property fields based on read_only expression --- frappe/public/js/form_builder/components/FieldProperties.vue | 2 +- frappe/public/js/form_builder/utils.js | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/form_builder/components/FieldProperties.vue b/frappe/public/js/form_builder/components/FieldProperties.vue index 7bd8d9be0d..c0bc205072 100644 --- a/frappe/public/js/form_builder/components/FieldProperties.vue +++ b/frappe/public/js/form_builder/components/FieldProperties.vue @@ -48,7 +48,7 @@ let docfield_df = computed(() => { class="mb-2 form-control form-control-sm" type="text" v-model="store.selected_field[df.fieldname]" - :disabled="store.read_only" + :disabled="store.read_only || df.read_only" />
{{ df.description }}
diff --git a/frappe/public/js/form_builder/utils.js b/frappe/public/js/form_builder/utils.js index 015744d7e5..1a60a6751e 100644 --- a/frappe/public/js/form_builder/utils.js +++ b/frappe/public/js/form_builder/utils.js @@ -125,11 +125,16 @@ export function get_table_columns(df) { } export function evaluate_depends_on_value(expression, doc) { + let store = useStore(); if (!doc) return; let out = null; let parent = doc || null; + if (!store.is_customize_form) { + parent = store.doc; + } + if (typeof expression === "boolean") { out = expression; } else if (typeof expression === "function") {