From b3450cd8681aab0ccdb4c37ec57b1bac7ed9219b Mon Sep 17 00:00:00 2001 From: sokumon Date: Fri, 20 Feb 2026 03:27:48 +0530 Subject: [PATCH 1/2] fix(minor): add tooltip for group sidebar items --- frappe/public/js/frappe/ui/sidebar/sidebar_card.js | 13 +++++++------ frappe/public/js/frappe/ui/sidebar/sidebar_item.js | 1 - 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/frappe/public/js/frappe/ui/sidebar/sidebar_card.js b/frappe/public/js/frappe/ui/sidebar/sidebar_card.js index 45799a6fbc..bcd00368b4 100644 --- a/frappe/public/js/frappe/ui/sidebar/sidebar_card.js +++ b/frappe/public/js/frappe/ui/sidebar/sidebar_card.js @@ -22,17 +22,18 @@ frappe.ui.SidebarCard = class SidebarCard { if (!this.icon) { this.icon = "info"; } - if (this.dismiss_it_for) { - const next_time_for_show = localStorage.getItem(this.get_dismiss_key()); - if (next_time_for_show && Date.now() < Number(next_time_for_show)) { - this.hide(); - } - } this.card = $( frappe.render_template("sidebar_card", { card: this, }) ); + if (this.dismiss_it_for) { + const next_time_for_show = localStorage.getItem(this.get_dismiss_key()); + if (next_time_for_show && Date.now() < Number(next_time_for_show)) { + this.hide(); + return; + } + } if (this.popper) { this.popper = createPopper($(this.trigger).get(0), $(this.parent).get(0), { modifiers: [ diff --git a/frappe/public/js/frappe/ui/sidebar/sidebar_item.js b/frappe/public/js/frappe/ui/sidebar/sidebar_item.js index 067af8afb3..21f62c0915 100644 --- a/frappe/public/js/frappe/ui/sidebar/sidebar_item.js +++ b/frappe/public/js/frappe/ui/sidebar/sidebar_item.js @@ -234,7 +234,6 @@ frappe.ui.sidebar_item.TypeSectionBreak = class SectionBreakSidebarItem extends } else { $(me.wrapper.find(".section-break")).addClass("hidden"); $(me.wrapper.find(".divider")).removeClass("hidden"); - $(me.wrapper).removeAttr("data-original-title"); me.old_state = me.collapsed; me.open(); if (me.item.indent) { From adb537e46b6262925171ca1563615b8076c7c2e8 Mon Sep 17 00:00:00 2001 From: sokumon Date: Fri, 20 Feb 2026 03:31:16 +0530 Subject: [PATCH 2/2] fix: route using title --- frappe/desk/page/desktop/desktop.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/desk/page/desktop/desktop.js b/frappe/desk/page/desktop/desktop.js index 7f3cf14365..2690d5dd74 100644 --- a/frappe/desk/page/desktop/desktop.js +++ b/frappe/desk/page/desktop/desktop.js @@ -73,7 +73,7 @@ function get_route(desktop_icon) { if (workspaces) { let args = { type: "workspace", - name: first_link.link_to, + name: workspaces.title, public: workspaces.public ? 1 : 0, route_options: { sidebar: desktop_icon.label,