vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #9772 from Thunderbottom/sidebar-typeof

Browse source 
fix: use typeof instead of instanceof
This commit is contained in:
Suraj Shetty 2020-03-24 13:41:36 +05:30 • committed by GitHub
commit d515e8a7be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frappe/public/js/frappe/list/list_sidebar_group_by.js
View file

@ -167,7 +167,7 @@ frappe.views.ListGroupBy = class ListGroupBy {
this.$wrapper.on('click', '.group-by-item', (e) => {
let $target = $(e.currentTarget);
let fieldname = $target.parents('.group-by-field').find('a').data('fieldname');
let value = $target.data('value') instanceof String? decodeURIComponent($target.data('value').trim()): $target.data('value');
let value = typeof $target.data('value') === 'string' ? decodeURIComponent($target.data('value').trim()) : $target.data('value');
fieldname = fieldname === 'assigned_to' ? '_assign': fieldname;
return this.list_view.filter_area.remove(fieldname)