From d5a21a26769ef0a487ecfed42a50ffbde682336b Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sun, 3 Sep 2023 19:46:31 +0530 Subject: [PATCH] fix: rename type validation `None` can be passed which is acceptable here. TODO: Make slackdict accept none as bool and convert to False --- frappe/model/document.py | 4 +--- frappe/utils/typing_validations.py | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/frappe/model/document.py b/frappe/model/document.py index 2d57922064..9cfb3057bd 100644 --- a/frappe/model/document.py +++ b/frappe/model/document.py @@ -1041,9 +1041,7 @@ class Document(BaseDocument): return self._cancel() @frappe.whitelist() - def rename( - self, name: str, merge: bool = False, force: bool = False, validate_rename: bool = True - ): + def rename(self, name: str, merge=False, force=False, validate_rename=True): """Rename the document to `name`. This transforms the current object.""" return self._rename(name=name, merge=merge, force=force, validate_rename=validate_rename) diff --git a/frappe/utils/typing_validations.py b/frappe/utils/typing_validations.py index 3f24c5eb19..cd8e736fe6 100644 --- a/frappe/utils/typing_validations.py +++ b/frappe/utils/typing_validations.py @@ -1,7 +1,7 @@ from collections.abc import Callable from functools import lru_cache, wraps from inspect import _empty, isclass, signature -from types import EllipsisType +from types import EllipsisType, NoneType from typing import ForwardRef, TypeVar, Union from pydantic import ConfigDict