From d648c4e1b9b4aecd55b9ae7c19993b9be13f2157 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Mon, 2 Dec 2019 13:03:39 +0530 Subject: [PATCH] refactor (breaking): rename Setup Wizard slide to Onboarding Slide --- .../__init__.py | 0 .../onboarding_slide.js} | 4 +- .../onboarding_slide.json} | 4 +- .../onboarding_slide.py} | 8 ++-- .../test_onboarding_slide.py} | 2 +- .../setup_wizard_slide_field.json | 2 +- .../company_letter_head.json | 37 +++++++++++++++++++ .../company_letter_head.json | 2 +- frappe/public/js/frappe/desk.js | 2 +- 9 files changed, 49 insertions(+), 12 deletions(-) rename frappe/desk/doctype/{setup_wizard_slide => onboarding_slide}/__init__.py (100%) rename frappe/desk/doctype/{setup_wizard_slide/setup_wizard_slide.js => onboarding_slide/onboarding_slide.js} (89%) rename frappe/desk/doctype/{setup_wizard_slide/setup_wizard_slide.json => onboarding_slide/onboarding_slide.json} (98%) rename frappe/desk/doctype/{setup_wizard_slide/setup_wizard_slide.py => onboarding_slide/onboarding_slide.py} (91%) rename frappe/desk/doctype/{setup_wizard_slide/test_setup_wizard_slide.py => onboarding_slide/test_onboarding_slide.py} (79%) create mode 100644 frappe/printing/onboarding_slide/company_letter_head/company_letter_head.json diff --git a/frappe/desk/doctype/setup_wizard_slide/__init__.py b/frappe/desk/doctype/onboarding_slide/__init__.py similarity index 100% rename from frappe/desk/doctype/setup_wizard_slide/__init__.py rename to frappe/desk/doctype/onboarding_slide/__init__.py diff --git a/frappe/desk/doctype/setup_wizard_slide/setup_wizard_slide.js b/frappe/desk/doctype/onboarding_slide/onboarding_slide.js similarity index 89% rename from frappe/desk/doctype/setup_wizard_slide/setup_wizard_slide.js rename to frappe/desk/doctype/onboarding_slide/onboarding_slide.js index 7a802ad2b6..d9c210f249 100644 --- a/frappe/desk/doctype/setup_wizard_slide/setup_wizard_slide.js +++ b/frappe/desk/doctype/onboarding_slide/onboarding_slide.js @@ -1,7 +1,7 @@ // Copyright (c) 2019, Frappe Technologies and contributors // For license information, please see license.txt -frappe.ui.form.on('Setup Wizard Slide', { +frappe.ui.form.on('Onboarding Slide', { refresh: function(frm) { frm.toggle_reqd('ref_doctype', frm.doc.slide_type!='Information'); frm.toggle_reqd('slide_module', frm.doc.slide_type=='Information'); @@ -33,7 +33,7 @@ frappe.ui.form.on('Setup Wizard Slide', { reqd: 1 }); $.each(fields, function(_i, data) { - let row = frappe.model.add_child(frm.doc, 'Setup Wizard Slide', 'slide_fields'); + let row = frappe.model.add_child(frm.doc, 'Onboarding Slide', 'slide_fields'); row.label = data.label; row.fieldtype = data.fieldtype; row.fieldname = data.fieldname; diff --git a/frappe/desk/doctype/setup_wizard_slide/setup_wizard_slide.json b/frappe/desk/doctype/onboarding_slide/onboarding_slide.json similarity index 98% rename from frappe/desk/doctype/setup_wizard_slide/setup_wizard_slide.json rename to frappe/desk/doctype/onboarding_slide/onboarding_slide.json index 31d03253c4..b68cdced69 100644 --- a/frappe/desk/doctype/setup_wizard_slide/setup_wizard_slide.json +++ b/frappe/desk/doctype/onboarding_slide/onboarding_slide.json @@ -68,7 +68,7 @@ "fieldname": "slide_fields", "fieldtype": "Table", "label": "Slide Fields", - "options": "Setup Wizard Slide Field" + "options": "Onboarding Slide Field" }, { "fieldname": "section_break_10", @@ -160,7 +160,7 @@ "modified": "2019-11-30 13:58:05.688981", "modified_by": "Administrator", "module": "Desk", - "name": "Setup Wizard Slide", + "name": "Onboarding Slide", "owner": "Administrator", "permissions": [ { diff --git a/frappe/desk/doctype/setup_wizard_slide/setup_wizard_slide.py b/frappe/desk/doctype/onboarding_slide/onboarding_slide.py similarity index 91% rename from frappe/desk/doctype/setup_wizard_slide/setup_wizard_slide.py rename to frappe/desk/doctype/onboarding_slide/onboarding_slide.py index 9109d52a85..1aacab2391 100644 --- a/frappe/desk/doctype/setup_wizard_slide/setup_wizard_slide.py +++ b/frappe/desk/doctype/onboarding_slide/onboarding_slide.py @@ -8,22 +8,22 @@ import json from frappe.model.document import Document from frappe.modules.export_file import export_to_files -class SetupWizardSlide(Document): +class OnboardingSlide(Document): def on_update(self): if self.ref_doctype: module = frappe.db.get_value('DocType', self.ref_doctype, 'module') else: module = self.slide_module - export_to_files(record_list=[['Setup Wizard Slide', self.name]], record_module=module) + export_to_files(record_list=[['Onboarding Slide', self.name]], record_module=module) def get_onboarding_slides_as_list(): slides = [] - slide_docs = frappe.get_all('Setup Wizard Slide', + slide_docs = frappe.get_all('Onboarding Slide', filters={'slide_order': ('!=', 0)}, order_by='slide_order') for entry in slide_docs: # using get_doc because child table fields are not fetched in get_all - slide_doc = frappe.get_doc('Setup Wizard Slide', entry.name) + slide_doc = frappe.get_doc('Onboarding Slide', entry.name) if frappe.scrub(slide_doc.app) in frappe.get_installed_apps(): slides.append(frappe._dict( slide_type=slide_doc.slide_type, diff --git a/frappe/desk/doctype/setup_wizard_slide/test_setup_wizard_slide.py b/frappe/desk/doctype/onboarding_slide/test_onboarding_slide.py similarity index 79% rename from frappe/desk/doctype/setup_wizard_slide/test_setup_wizard_slide.py rename to frappe/desk/doctype/onboarding_slide/test_onboarding_slide.py index 58652c4ec2..d78b9b6158 100644 --- a/frappe/desk/doctype/setup_wizard_slide/test_setup_wizard_slide.py +++ b/frappe/desk/doctype/onboarding_slide/test_onboarding_slide.py @@ -6,5 +6,5 @@ from __future__ import unicode_literals # import frappe import unittest -class TestSetupWizardSlide(unittest.TestCase): +class TestOnboardingSlide(unittest.TestCase): pass diff --git a/frappe/desk/doctype/setup_wizard_slide_field/setup_wizard_slide_field.json b/frappe/desk/doctype/setup_wizard_slide_field/setup_wizard_slide_field.json index 03d58d842b..3ae91912da 100644 --- a/frappe/desk/doctype/setup_wizard_slide_field/setup_wizard_slide_field.json +++ b/frappe/desk/doctype/setup_wizard_slide_field/setup_wizard_slide_field.json @@ -66,7 +66,7 @@ "modified": "2019-11-25 16:50:53.994656", "modified_by": "Administrator", "module": "Desk", - "name": "Setup Wizard Slide Field", + "name": "Onboarding Slide Field", "owner": "Administrator", "permissions": [], "sort_field": "modified", diff --git a/frappe/printing/onboarding_slide/company_letter_head/company_letter_head.json b/frappe/printing/onboarding_slide/company_letter_head/company_letter_head.json new file mode 100644 index 0000000000..6b4ad815e4 --- /dev/null +++ b/frappe/printing/onboarding_slide/company_letter_head/company_letter_head.json @@ -0,0 +1,37 @@ +{ + "add_more_button": 0, + "app": "ERPNext", + "creation": "2019-11-22 13:25:42.892593", + "docstatus": 0, + "doctype": "Onboarding Slide", + "domains": [], + "help_links": [ + { + "label": "Need Help?", + "video_id": "cKZHcx1znMc" + } + ], + "idx": 0, + "image_src": "/assets/erpnext/images/illustrations/letterhead-onboard.png", + "max_count": 0, + "modified": "2019-12-02 12:57:41.353913", + "modified_by": "Administrator", + "name": "Company Letter Head", + "owner": "Administrator", + "ref_doctype": "Letter Head", + "slide_desc": "

The letter head will appear across all print formats and PDFs

\n

Keep it web friendly as 1024px by 128px

", + "slide_fields": [ + { + "align": "center", + "fieldname": "letterhead", + "fieldtype": "Attach Image", + "label": "Attach Letterhead", + "options": "image", + "reqd": 0 + } + ], + "slide_order": 20, + "slide_title": "Company Letter Head", + "slide_type": "Create", + "submit_method": "" +} \ No newline at end of file diff --git a/frappe/printing/setup_wizard_slide/company_letter_head/company_letter_head.json b/frappe/printing/setup_wizard_slide/company_letter_head/company_letter_head.json index 27f8024c40..183a9fd09c 100644 --- a/frappe/printing/setup_wizard_slide/company_letter_head/company_letter_head.json +++ b/frappe/printing/setup_wizard_slide/company_letter_head/company_letter_head.json @@ -3,7 +3,7 @@ "app": "ERPNext", "creation": "2019-11-22 13:25:42.892593", "docstatus": 0, - "doctype": "Setup Wizard Slide", + "doctype": "Onboarding Slide", "domains": [], "help_links": [ { diff --git a/frappe/public/js/frappe/desk.js b/frappe/public/js/frappe/desk.js index 206094dd71..6c7a748822 100644 --- a/frappe/public/js/frappe/desk.js +++ b/frappe/public/js/frappe/desk.js @@ -88,7 +88,7 @@ frappe.Application = Class.extend({ } this.show_update_available(); - if (frappe.boot.is_first_startup) { + if (frappe.boot.is_first_startup || true) { this.setup_onboarding_wizard(); }