vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: proper msg for users with role (#35099)

Browse source 
* refactor: proper msg for users with role

* refactor: better UI for showing users with role

* refactor: filter with role name instead usernames

* chore: simplify user list display in permission manager
This commit is contained in:
Abdeali Chharchhodawala 2025-12-18 18:45:01 +05:30 • committed by GitHub
parent 45c0696c57
commit d6c19e856d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 56 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

67
frappe/core/page/permission_manager/permission_manager.js
View file

@ -344,23 +344,68 @@ frappe.PermissionEngine = class PermissionEngine {
.find("a")
.attr("data-role", role)
.click(function () {
let role = $(this).attr("data-role");
const role = $(this).attr("data-role");
frappe.call({
module: "frappe.core",
page: "permission_manager",
method: "get_users_with_role",
args: {
role: role,
},
args: { role },
callback: function (r) {
r.message = $.map(r.message, function (p) {
return $.format('<a href="/app/user/{0}">{1}</a>', [p, p]);
let message_html = "";
const role_label = __(role);
const users = (r.message || []).filter(Boolean);
const user_count = users.length;
const display_count = Math.min(user_count, 5);
if (user_count === 0) {
message_html = __("No user has the role <strong>{0}</strong>", [
role_label,
]);
} else {
const user_text = user_count === 1 ? __("User") : __("Users");
const display_users = users.slice(0, display_count);
const user_list = display_users
.map(
(user) =>
`<li class="py-1">
${frappe.utils.get_form_link("User", user, true)}
</li>`
)
.join("");
message_html = __("{0} with the role <strong>{1}</strong>", [
user_text,
role_label,
]);
message_html += `<ul class="border rounded pl-4 pb-2 pt-2 mb-3 mt-3">${user_list}</ul>`;
// show compact "View All" link if more users
if (user_count > display_count) {
const route = frappe.utils.generate_route({
type: "Doctype",
doctype: "User",
name: "User",
doc_view: "List",
route_options: { role },
});
message_html += `<div class="text-center">
<a href="${route}" class="text-muted">
${frappe.utils.icon("external-link", "sm", "mr-1")}
${__("View all {0} users", [user_count])}
</a>
</div>`;
}
}
frappe.msgprint({
title: __("Users"),
message: message_html,
indicator: user_count === 0 ? "orange" : "blue",
});
frappe.msgprint(
__("Users with role {0}:", [__(role)]) +
"<br>" +
r.message.join("<br>")
);
},
});
return false;