From aa2360e589368d58b909fc9f49ad9dd028990da4 Mon Sep 17 00:00:00 2001 From: Saqib Ansari Date: Thu, 7 Jan 2021 14:46:32 +0530 Subject: [PATCH 1/2] fix: cannot refresh grid_row --- frappe/public/js/frappe/form/script_helpers.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/frappe/form/script_helpers.js b/frappe/public/js/frappe/form/script_helpers.js index 83ba191d4d..a0caae33e5 100644 --- a/frappe/public/js/frappe/form/script_helpers.js +++ b/frappe/public/js/frappe/form/script_helpers.js @@ -18,15 +18,17 @@ window.refresh_field = function(n, docname, table_field) { if (n && typeof n==='string' && table_field){ var grid = cur_frm.fields_dict[table_field].grid, - field = frappe.utils.filter_dict(grid.docfields, {fieldname: n}); + field = frappe.utils.filter_dict(grid.docfields, {fieldname: n}), + grid_row = grid.grid_rows_by_docname[docname]; + if (field && field.length){ field = field[0]; var meta = frappe.meta.get_docfield(field.parent, field.fieldname, docname); $.extend(field, meta); - if (docname){ - cur_frm.fields_dict[table_field].grid.grid_rows_by_docname[docname].refresh_field(n); + if (grid_row){ + grid_row.refresh_field(n); } else { - cur_frm.fields_dict[table_field].grid.refresh(); + grid.refresh(); } } } else if(cur_frm) { From 4806dcff32fa4f3187c05877659741bb7b67179c Mon Sep 17 00:00:00 2001 From: Saqib Ansari Date: Mon, 11 Jan 2021 14:26:05 +0530 Subject: [PATCH 2/2] fix: sider issues --- frappe/public/js/frappe/form/script_helpers.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/form/script_helpers.js b/frappe/public/js/frappe/form/script_helpers.js index a0caae33e5..0465624975 100644 --- a/frappe/public/js/frappe/form/script_helpers.js +++ b/frappe/public/js/frappe/form/script_helpers.js @@ -16,16 +16,16 @@ window.refresh_field = function(n, docname, table_field) { if(typeof n==typeof []) refresh_many(n, docname, table_field); - if (n && typeof n==='string' && table_field){ + if (n && typeof n==='string' && table_field) { var grid = cur_frm.fields_dict[table_field].grid, field = frappe.utils.filter_dict(grid.docfields, {fieldname: n}), grid_row = grid.grid_rows_by_docname[docname]; - if (field && field.length){ + if (field && field.length) { field = field[0]; var meta = frappe.meta.get_docfield(field.parent, field.fieldname, docname); $.extend(field, meta); - if (grid_row){ + if (grid_row) { grid_row.refresh_field(n); } else { grid.refresh();