From 71fc4cbd3a1b5168633aed807074cf7abd5885cc Mon Sep 17 00:00:00 2001 From: Aditya Hase Date: Thu, 20 Jun 2019 11:09:35 +0530 Subject: [PATCH] fix: Trigger notifications after updating last_login, last_ip fields Notifications for User doctype based on Value Change in last_ip, last_login, last_active aren't triggered because of updates performed through frappe.db.sql. This behavior is fixed by explicitly triggering notifications. --- frappe/sessions.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/sessions.py b/frappe/sessions.py index 81ba75af96..af57b94056 100644 --- a/frappe/sessions.py +++ b/frappe/sessions.py @@ -231,6 +231,7 @@ class Session: self.insert_session_record() # update user + user = frappe.get_doc("User", self.data['user']) frappe.db.sql("""UPDATE `tabUser` SET last_login = %(now)s, @@ -241,7 +242,8 @@ class Session: 'ip': frappe.local.request_ip, 'name': self.data['user'] }) - + user.run_notifications("before_change") + user.run_notifications("on_update") frappe.db.commit() def insert_session_record(self):