From d8c777e98cc12d159b7f000885d630cbf759d7e5 Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Fri, 30 Apr 2021 10:43:07 +0530 Subject: [PATCH] refactor: Remove unnecessary code --- frappe/boot.py | 2 -- frappe/public/js/frappe/desk.js | 11 ----------- frappe/public/js/frappe/utils/utils.js | 25 ------------------------- 3 files changed, 38 deletions(-) diff --git a/frappe/boot.py b/frappe/boot.py index 65a07b15e5..0dfcb8d1b4 100644 --- a/frappe/boot.py +++ b/frappe/boot.py @@ -42,8 +42,6 @@ def get_bootinfo(): bootinfo.user_info = get_user_info() bootinfo.sid = frappe.session['sid'] - bootinfo.user_groups = frappe.get_all('User Group', pluck="name") - bootinfo.modules = {} bootinfo.module_list = [] load_desktop_data(bootinfo) diff --git a/frappe/public/js/frappe/desk.js b/frappe/public/js/frappe/desk.js index c093a73689..2331766710 100644 --- a/frappe/public/js/frappe/desk.js +++ b/frappe/public/js/frappe/desk.js @@ -114,8 +114,6 @@ frappe.Application = Class.extend({ dialog.get_close_btn().toggle(false); }); - this.setup_user_group_listeners(); - // listen to build errors this.setup_build_error_listener(); @@ -593,15 +591,6 @@ frappe.Application = Class.extend({ } }, - setup_user_group_listeners() { - frappe.realtime.on('user_group_added', (user_group) => { - frappe.boot.user_groups && frappe.boot.user_groups.push(user_group); - }); - frappe.realtime.on('user_group_deleted', (user_group) => { - frappe.boot.user_groups = (frappe.boot.user_groups || []).filter(el => el !== user_group); - }); - }, - setup_energy_point_listeners() { frappe.realtime.on('energy_point_alert', (message) => { frappe.show_alert(message); diff --git a/frappe/public/js/frappe/utils/utils.js b/frappe/public/js/frappe/utils/utils.js index 7ce30a525c..8e6a458c3e 100644 --- a/frappe/public/js/frappe/utils/utils.js +++ b/frappe/public/js/frappe/utils/utils.js @@ -1272,31 +1272,6 @@ Object.assign(frappe.utils, { `); }, - get_names_for_mentions() { - let names_for_mentions = Object.keys(frappe.boot.user_info || []) - .filter(user => { - return !["Administrator", "Guest"].includes(user) - && frappe.boot.user_info[user].allowed_in_mentions - && frappe.boot.user_info[user].user_type === 'System User'; - }) - .map(user => { - return { - id: frappe.boot.user_info[user].name, - value: frappe.boot.user_info[user].fullname, - }; - }); - - frappe.boot.user_groups && frappe.boot.user_groups.map(group => { - names_for_mentions.push({ - id: group, - value: group, - is_group: true, - link: frappe.utils.get_form_link('User Group', group) - }); - }); - - return names_for_mentions; - }, print(doctype, docname, print_format, letterhead, lang_code) { let w = window.open( frappe.urllib.get_full_url(