From 296ba3c5a779adeb2c41d2b418f358a9086e6f41 Mon Sep 17 00:00:00 2001 From: Revant Nandgaonkar Date: Tue, 1 Dec 2015 12:40:40 +0530 Subject: [PATCH] Enter Recipients if communication_medium is Email https://github.com/frappe/frappe/issues/1359 Convenient to add communication via email dialog. Workaround maintaining valid email addresses in recipients --- frappe/public/js/frappe/views/communication.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/views/communication.js b/frappe/public/js/frappe/views/communication.js index 33a43818bb..106428e39e 100644 --- a/frappe/public/js/frappe/views/communication.js +++ b/frappe/public/js/frappe/views/communication.js @@ -51,7 +51,7 @@ frappe.views.CommunicationComposer = Class.extend({ var fields_before_cc = [ {fieldtype: "Section Break"}, - {label:__("To"), fieldtype:"Data", reqd: 1, fieldname:"recipients"}, + {label:__("To"), fieldtype:"Data", reqd: 0, fieldname:"recipients"}, {fieldtype: "Section Break", collapsible: 1, label: "CC & Standard Reply"}, {label:__("CC"), fieldtype:"Data", fieldname:"cc"}, ]; @@ -65,7 +65,7 @@ frappe.views.CommunicationComposer = Class.extend({ {fieldtype: "Section Break"}, {label:__("Message"), fieldtype:"Text Editor", reqd: 1, fieldname:"content"}, - {fieldtype: "Section Break"}, + {fieldtype: "Section Break"}, {fieldtype: "Column Break"}, {label:__("Send As Email"), fieldtype:"Check", fieldname:"send_email"}, @@ -399,6 +399,11 @@ frappe.views.CommunicationComposer = Class.extend({ send_email: function(btn, form_values, selected_attachments, print_html, print_format) { var me = this; + if((form_values.send_email || form_values.communication_medium === "Email") && !form_values.recipients){ + msgprint(__("Enter Email Recipient(s)")); + return; + } + if(!form_values.attach_document_print) { print_html = null; print_format = null;