From 8dd925743c59f735567d7f73395648e7c4fbb742 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 26 Apr 2021 22:16:18 +0530 Subject: [PATCH] feat(DX): sourceURL for injected javascript Adds sourceURL to injected javascript code, this helps in debugging injected javascript using client script or doctype specific javascript. `no-docs` --- frappe/desk/form/meta.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/frappe/desk/form/meta.py b/frappe/desk/form/meta.py index e637f4969a..087cc54d9d 100644 --- a/frappe/desk/form/meta.py +++ b/frappe/desk/form/meta.py @@ -109,8 +109,9 @@ class FormMeta(Meta): def _add_code(self, path, fieldname): js = get_js(path) if js: - self.set(fieldname, (self.get(fieldname) or "") - + "\n\n/* Adding {0} */\n\n".format(path) + js) + comment = f"\n\n/* Adding {path} */\n\n" + sourceURL = f"\n\n//# sourceURL={scrub(self.name) + fieldname}" + self.set(fieldname, (self.get(fieldname) or "") + comment + js + sourceURL) def add_html_templates(self, path): if self.custom: @@ -145,6 +146,10 @@ class FormMeta(Meta): if script.view == 'Form': form_script += script.script + file = scrub(self.name) + form_script += f"\n\n//# sourceURL={file}__custom_js" + list_script += f"\n\n//# sourceURL={file}__custom_list_js" + self.set("__custom_js", form_script) self.set("__custom_list_js", list_script)