Merge pull request #971 from nabinhait/fix1
Minor fixes: escaped characters
This commit is contained in:
commit
d9fc13d0e6
3 changed files with 6 additions and 5 deletions
|
|
@ -27,8 +27,8 @@ def get_permission_query_conditions(user):
|
|||
`tabEvent Role`.parent=tabEvent.name
|
||||
and `tabEvent Role`.role in ('%(roles)s')))
|
||||
""" % {
|
||||
"user": user,
|
||||
"roles": "', '".join(frappe.get_roles(user))
|
||||
"user": frappe.db.escape(user),
|
||||
"roles": "', '".join([frappe.db.escape(r) for r in frappe.get_roles(user)])
|
||||
}
|
||||
|
||||
def has_permission(doc, user):
|
||||
|
|
|
|||
|
|
@ -77,7 +77,8 @@ def get_permission_query_conditions(user):
|
|||
if "System Manager" in frappe.get_roles(user):
|
||||
return None
|
||||
else:
|
||||
return """(tabToDo.owner = '{user}' or tabToDo.assigned_by = '{user}')""".format(user=user)
|
||||
return """(tabToDo.owner = '{user}' or tabToDo.assigned_by = '{user}')"""\
|
||||
.format(user=frappe.db.escape(user))
|
||||
|
||||
def has_permission(doc, user):
|
||||
if "System Manager" in frappe.get_roles(user):
|
||||
|
|
|
|||
|
|
@ -187,11 +187,11 @@ def make_test_objects(doctype, test_records, verbose=None):
|
|||
records = []
|
||||
|
||||
if not frappe.get_meta(doctype).issingle:
|
||||
existing = frappe.get_list(doctype, filters={"name":("like", "_T-" + doctype + "-%")})
|
||||
existing = frappe.get_all(doctype, filters={"name":("like", "_T-" + doctype + "-%")})
|
||||
if existing:
|
||||
return [d.name for d in existing]
|
||||
|
||||
existing = frappe.get_list(doctype, filters={"name":("like", "_Test " + doctype + "%")})
|
||||
existing = frappe.get_all(doctype, filters={"name":("like", "_Test " + doctype + "%")})
|
||||
if existing:
|
||||
return [d.name for d in existing]
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue