From db4cd1a84b7acbdca1c6a97537ebd719703e9c6b Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Tue, 25 Apr 2023 15:03:11 +0530 Subject: [PATCH] refactor: reduce duplication --- frappe/utils/telemetry.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/frappe/utils/telemetry.py b/frappe/utils/telemetry.py index 6dcdf97da9..4042c0b65e 100644 --- a/frappe/utils/telemetry.py +++ b/frappe/utils/telemetry.py @@ -9,13 +9,16 @@ from posthog import Posthog import frappe +POSTHOG_PROJECT_FIELD = "posthog_project_id" +POSTHOG_HOST_FIELD = "posthog_host" + def add_bootinfo(bootinfo): if not frappe.get_system_settings("enable_telemetry"): return - bootinfo.posthog_host = frappe.conf.posthog_host - bootinfo.posthog_project_id = frappe.conf.posthog_project_id + bootinfo.posthog_host = frappe.conf.get(POSTHOG_HOST_FIELD) + bootinfo.posthog_project_id = frappe.conf.get(POSTHOG_PROJECT_FIELD) bootinfo.enable_telemetry = True @@ -27,8 +30,8 @@ def init_telemetry(): if not frappe.get_system_settings("enable_telemetry"): return - posthog_host = frappe.conf.posthog_host - posthog_project_id = frappe.conf.posthog_project_id + posthog_host = frappe.conf.get(POSTHOG_HOST_FIELD) + posthog_project_id = frappe.conf.get(POSTHOG_PROJECT_FIELD) if not posthog_host or not posthog_project_id: return