From dbc5a790c14441e2578a41b5890d0590145b7dfb Mon Sep 17 00:00:00 2001 From: Ritwik Puri Date: Thu, 8 Dec 2022 12:49:23 +0530 Subject: [PATCH] fix(docshare): return None if share_name and value are None (#19187) --- frappe/share.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/share.py b/frappe/share.py index 2cdca9af91..adae95ea23 100644 --- a/frappe/share.py +++ b/frappe/share.py @@ -98,8 +98,8 @@ def set_docshare_permission(doctype, name, user, permission_to, value=1, everyon share = add_docshare(doctype, name, user, everyone=everyone, **{permission_to: 1}, flags=flags) else: # no share found, nothing to remove - share = {} - pass + share = None + else: share = frappe.get_doc("DocShare", share_name) if flags: