vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(sqlite): don't allow starting nested transactions

Browse source 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2025-03-28 12:18:15 +05:30
parent 7d62f22a3a
commit dc60a65c38
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frappe/database/sqlite/database.py
View file

@ -93,6 +93,10 @@ class SQLiteExceptionUtil:
def is_interface_error(e: sqlite3.Error):
return isinstance(e, sqlite3.InterfaceError)
@staticmethod
def is_nested_transaction_error(e: sqlite3.Error):
return "cannot start a transaction within a transaction" in str(e)
class SQLiteDatabase(SQLiteExceptionUtil, Database):
REGEX_CHARACTER = "regexp"
@ -452,7 +456,11 @@ class SQLiteDatabase(SQLiteExceptionUtil, Database):
self._cursor = self._conn.cursor()
self.read_only = False
self.sql("BEGIN")
try:
self.sql("BEGIN")
except sqlite3.OperationalError as e:
if not self.is_nested_transaction_error(e):
raise e
def commit(self):
"""Commit current transaction. Calls SQL `COMMIT`."""