From 5b75ac9d22f290800bb4393e40fc570b2bae553e Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Thu, 22 Dec 2022 11:30:47 +0530 Subject: [PATCH 1/3] feat(minor): show fieldname on hover in non-dev mode when cmd/ctrl is pressed --- .../public/js/frappe/form/controls/base_control.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/frappe/public/js/frappe/form/controls/base_control.js b/frappe/public/js/frappe/form/controls/base_control.js index 9d9c919e97..9f3f53cad6 100644 --- a/frappe/public/js/frappe/form/controls/base_control.js +++ b/frappe/public/js/frappe/form/controls/base_control.js @@ -6,6 +6,18 @@ frappe.ui.form.Control = class BaseControl { // if developer_mode=1, show fieldname as tooltip if (frappe.boot.user && frappe.boot.developer_mode === 1 && this.$wrapper) { this.$wrapper.attr("title", __(this.df.fieldname)); + } else if (this.$wrapper) { + // show fieldname as tooltip when cmd/ctrl key is pressed + $(document).on("keydown", (e) => { + if (e.metaKey) { + this.$wrapper.attr("title", __(this.df.fieldname)); + } + }); + $(document).on("keyup", (e) => { + if (!e.metaKey) { + this.$wrapper.removeAttr("title"); + } + }); } if (this.render_input) { From 8c9c9b9f3728bd35f1df09f47d7b8fd5dcbb14a0 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Thu, 22 Dec 2022 17:46:14 +0530 Subject: [PATCH 2/3] fix: support ctrl key for linux/windows --- frappe/public/js/frappe/form/layout.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/form/layout.js b/frappe/public/js/frappe/form/layout.js index 10c9abb431..557af26e2e 100644 --- a/frappe/public/js/frappe/form/layout.js +++ b/frappe/public/js/frappe/form/layout.js @@ -532,12 +532,12 @@ frappe.ui.form.Layout = class Layout { setup_tooltip_events() { $(document).on("keydown", (e) => { - if (e.metaKey) { + if (e.metaKey || e.ctrlKey) { this.wrapper.addClass("show-tooltip"); } }); $(document).on("keyup", (e) => { - if (!e.metaKey) { + if (!e.metaKey || e.ctrlKey) { this.wrapper.removeClass("show-tooltip"); } }); From 64569c39eb42fdb987aa466f0729de0796fce03d Mon Sep 17 00:00:00 2001 From: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> Date: Thu, 22 Dec 2022 17:48:47 +0530 Subject: [PATCH 3/3] fix: missed not operator --- frappe/public/js/frappe/form/layout.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/layout.js b/frappe/public/js/frappe/form/layout.js index 557af26e2e..b425bfd475 100644 --- a/frappe/public/js/frappe/form/layout.js +++ b/frappe/public/js/frappe/form/layout.js @@ -537,7 +537,7 @@ frappe.ui.form.Layout = class Layout { } }); $(document).on("keyup", (e) => { - if (!e.metaKey || e.ctrlKey) { + if (!e.metaKey || !e.ctrlKey) { this.wrapper.removeClass("show-tooltip"); } });