vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: skip 0 for rounding

Browse source
This commit is contained in:
Ankush Menat 2023-03-13 14:14:17 +05:30
parent 02168174c1
commit dd2ac72a9a
3 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
frappe/public/js/frappe/utils/number_format.js
View file

@ -189,6 +189,7 @@ function _round(num, precision, rounding_method) {
r = d ? r / m : r;
return is_negative ? -r : r;
} else if (rounding_method == "Banker's Rounding") {
if (num == 0) return 0.0;
precision = cint(precision);
let multiplier = Math.pow(10, precision);

2
frappe/tests/test_utils.py
View file

@ -63,6 +63,7 @@ from frappe.utils.data import (
now_datetime,
nowtime,
pretty_date,
rounded,
to_timedelta,
validate_python_code,
)
@ -1094,6 +1095,7 @@ class TestRounding(FrappeTestCase):
def test_bankers_rounding(self):
rounding_method = "Banker's Rounding"
self.assertEqual(rounded(0, 0, rounding_method=rounding_method), 0)
self.assertEqual(flt("0.5", 0, rounding_method=rounding_method), 0)
self.assertEqual(flt("0.3", rounding_method=rounding_method), 0.3)

3
frappe/utils/data.py
View file

@ -1117,6 +1117,9 @@ def _round_away_from_zero(num, precision):
def _bankers_rounding(num, precision):
if num == 0:
return 0.0
multiplier = 10**precision
num = round(num * multiplier, 12)