From dd86c48306216d60d0893e9cadebdcbae2247dc4 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 9 Nov 2023 20:10:14 +0530 Subject: [PATCH] fix: Ignore `None` returned by RQ job Even though type signature suggests that it always returns job object it sometimes doesn't if you read the code. --- frappe/core/doctype/rq_job/rq_job.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/rq_job/rq_job.py b/frappe/core/doctype/rq_job/rq_job.py index b6a6f99b57..453a375a5a 100644 --- a/frappe/core/doctype/rq_job/rq_job.py +++ b/frappe/core/doctype/rq_job/rq_job.py @@ -87,7 +87,9 @@ class RQJob(Document): matched_job_ids = RQJob.get_matching_job_ids(args)[start : start + page_length] conn = get_redis_conn() - jobs = [serialize_job(job) for job in Job.fetch_many(job_ids=matched_job_ids, connection=conn)] + jobs = [ + serialize_job(job) for job in Job.fetch_many(job_ids=matched_job_ids, connection=conn) if job + ] return sorted(jobs, key=lambda j: j.modified, reverse=order_desc)