vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(money_in_words)!: Don't translate the result of num2words

Browse source 
It's unlikely that a translation for the results of num2words exists, because it should return a string that is already translated in the target language. If there are some numbers that have a specific translation, then it should already be handled in the num2words library. A domain-specific library is surely better at this hypothetical task than Frappe's generic translation system.

In French, 100 is called Cent. But in English, Cent is 1/100th of a dollar, which is called Centime in French.
Expected: num2words(200).title() == "Cent"
Actual: _(num2words(200).title()) == _("Cent") == "Centime"
This commit is contained in:
Corentin Flr 2024-01-26 15:25:23 +01:00
parent 63e2e2db56
commit dde34f9402
No known key found for this signature in database
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
frappe/utils/data.py
View file

@ -1518,18 +1518,12 @@ def money_in_words(
out = _(main_currency, context="Currency") + " " + _("Zero")
# 0.XX
elif main == "0":
out = _(in_words(fraction, in_million).title()) + " " + fraction_currency
out = in_words(fraction, in_million).title() + " " + fraction_currency
else:
out = _(main_currency, context="Currency") + " " + _(in_words(main, in_million).title())
out = _(main_currency, context="Currency") + " " + in_words(main, in_million).title()
if cint(fraction):
out = (
out
+ " "
+ _("and")
+ " "
+ _(in_words(fraction, in_million).title())
+ " "
+ fraction_currency
out + " " + _("and") + " " + in_words(fraction, in_million).title() + " " + fraction_currency
)
return _("{0} only.", context="Money in words").format(out)