From c15466c521c5e7361dee01d6aaa36a34dd11ea76 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Wed, 23 Oct 2019 15:31:12 +0530 Subject: [PATCH] fix: added title_field to filters, removed search icon --- frappe/public/js/frappe/list/base_list.js | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/frappe/public/js/frappe/list/base_list.js b/frappe/public/js/frappe/list/base_list.js index fef7f954bc..648a3d6d55 100644 --- a/frappe/public/js/frappe/list/base_list.js +++ b/frappe/public/js/frappe/list/base_list.js @@ -590,7 +590,7 @@ class FilterArea { let fields = [ { fieldtype: 'Data', - label: 'ID', + label: 'Name', condition: 'like', fieldname: 'name', onchange: () => this.refresh_list_view() @@ -606,9 +606,10 @@ class FilterArea { } const doctype_fields = this.list_view.meta.fields; + const title_field = this.list_view.meta.title_field; + fields = fields.concat(doctype_fields.filter( - df => df.in_standard_filter && - frappe.model.is_value_type(df.fieldtype) + df => (df.fieldname === title_field) || (df.in_standard_filter && frappe.model.is_value_type(df.fieldtype)) ).map(df => { let options = df.options; let condition = '='; @@ -641,21 +642,6 @@ class FilterArea { })); fields.map(df => this.list_view.page.add_field(df)); - - // search icon in name filter - $('') - .appendTo(this.list_view.page.fields_dict.name.$wrapper) - .css({ - 'position': 'absolute', - 'z-index': '1', - 'right': '7px', - 'top': '9px', - 'font-size': '90%' - }); - - this.list_view.page.fields_dict.name.$wrapper - .find('.form-control') - .css('padding-right', '2em'); } get_standard_filters() {