vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #31516 from sagarvora/sumbitted

Browse source 
chore: fix typo in new `DocStatus` constant
This commit is contained in:
Sagar Vora 2025-03-05 08:39:20 +05:30 • committed by GitHub
commit de3dd1ce8e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/desk/form/save.py
View file

@ -29,8 +29,8 @@ def savedocs(doc, action):
# action
doc.docstatus = {
"Save": DocStatus.DRAFT,
"Submit": DocStatus.SUMBITTED,
"Update": DocStatus.SUMBITTED,
"Submit": DocStatus.SUBMITTED,
"Update": DocStatus.SUBMITTED,
"Cancel": DocStatus.CANCELLED,
}[action]

6
frappe/model/docstatus.py
View file

@ -7,7 +7,7 @@ class DocStatus(int):
return self == DocStatus.DRAFT
def is_submitted(self):
return self == DocStatus.SUMBITTED
return self == DocStatus.SUBMITTED
def is_cancelled(self):
return self == DocStatus.CANCELLED
@ -20,7 +20,7 @@ class DocStatus(int):
@staticmethod
def submitted():
return DocStatus.SUMBITTED
return DocStatus.SUBMITTED
@staticmethod
def cancelled():
@ -28,5 +28,5 @@ class DocStatus(int):
DocStatus.DRAFT = DocStatus(0)
DocStatus.SUMBITTED = DocStatus(1)
DocStatus.SUBMITTED = DocStatus(1)
DocStatus.CANCELLED = DocStatus(2)

4
frappe/model/document.py
View file

@ -1008,7 +1008,7 @@ class Document(BaseDocument, DocRef):
else:
raise frappe.ValidationError(_("Invalid docstatus"), self.docstatus)
elif to_docstatus == DocStatus.SUMBITTED:
elif to_docstatus == DocStatus.SUBMITTED:
if self.docstatus.is_submitted():
self._action = "update_after_submit"
self.check_permission("submit")
@ -1188,7 +1188,7 @@ class Document(BaseDocument, DocRef):
def _submit(self):
"""Submit the document. Sets `docstatus` = 1, then saves."""
self.docstatus = DocStatus.SUMBITTED
self.docstatus = DocStatus.SUBMITTED
return self.save()
def _cancel(self):

8
frappe/tests/test_docstatus.py
View file

@ -11,11 +11,11 @@ class TestDocStatus(IntegrationTestCase):
self.assertFalse(DocStatus.DRAFT.is_submitted())
def test_submitted(self):
self.assertEqual(DocStatus(1), DocStatus.SUMBITTED)
self.assertEqual(DocStatus(1), DocStatus.SUBMITTED)
self.assertFalse(DocStatus.SUMBITTED.is_draft())
self.assertTrue(DocStatus.SUMBITTED.is_submitted())
self.assertFalse(DocStatus.SUMBITTED.is_cancelled())
self.assertFalse(DocStatus.SUBMITTED.is_draft())
self.assertTrue(DocStatus.SUBMITTED.is_submitted())
self.assertFalse(DocStatus.SUBMITTED.is_cancelled())
def test_cancelled(self):
self.assertEqual(DocStatus(2), DocStatus.CANCELLED)