From de45cf9bbd20f7d07b47936cad61854408820eec Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Thu, 5 May 2022 13:13:40 +0200
Subject: [PATCH] feat: Use autocomplete attributes for login, signup and
 password reset

---
 frappe/templates/signup.html    | 4 ++--
 frappe/www/login.html           | 4 ++--
 frappe/www/update-password.html | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/frappe/templates/signup.html b/frappe/templates/signup.html
index abc1328e25..7d93bdec85 100644
--- a/frappe/templates/signup.html
+++ b/frappe/templates/signup.html
@@ -3,12 +3,12 @@
         <div class="form-group">
             <label class="form-label sr-only" for="signup_fullname">{{ _("Full Name") }}</label>
             <input type="text" id="signup_fullname" class="form-control" placeholder="{{ _('Jane Doe') }}"
-                required autofocus>
+                required autofocus autocomplete="name">
         </div>
         <div class="form-group">
             <label class="form-label sr-only" for="signup_email">{{ _("Email") }}</label>
             <input type="email" id="signup_email" class="form-control"
-                placeholder="{{ _('jane@example.com') }}" required>
+                placeholder="{{ _('jane@example.com') }}" required autocomplete="username">
         </div>
     </div>
     <div class="page-card-actions">
diff --git a/frappe/www/login.html b/frappe/www/login.html
index 927f451965..1aaaf85656 100644
--- a/frappe/www/login.html
+++ b/frappe/www/login.html
@@ -7,7 +7,7 @@
 		<div class="email-field">
 			<input type="text" id="login_email" class="form-control"
 				placeholder="{% if login_name_placeholder %}{{ login_name_placeholder  }}{% else %}{{ _('jane@example.com') }}{% endif %}"
-				required autofocus>
+				required autofocus autocomplete="username">
 
 			<svg class="field-icon email-icon" width="20" height="20" viewBox="0 0 20 20" fill="none"
 				xmlns="http://www.w3.org/2000/svg">
@@ -152,7 +152,7 @@
 				<div class="page-card-body">
 					<div class="email-field">
 						<input type="email" id="forgot_email" class="form-control"
-							placeholder="{{ _('Email Address') }}" required autofocus>
+							placeholder="{{ _('Email Address') }}" required autofocus autocomplete="username">
 						<svg class="field-icon email-icon" width="20" height="20" viewBox="0 0 20 20" fill="none"
 							xmlns="http://www.w3.org/2000/svg">
 							<path
diff --git a/frappe/www/update-password.html b/frappe/www/update-password.html
index 5341d7a19c..04dfa5e097 100644
--- a/frappe/www/update-password.html
+++ b/frappe/www/update-password.html
@@ -12,16 +12,16 @@
 		<form id="reset-password">
 			<div class="form-group">
 				<input id="old_password" type="password"
-					class="form-control mb-4" placeholder="{{ _('Old Password') }}">
+					class="form-control mb-4" placeholder="{{ _('Old Password') }}" autocomplete="current-password">
 			</div>
 			<div class="form-group">
 				<input id="new_password" type="password"
-					class="form-control mb-4" placeholder="{{ _('New Password') }}">
+					class="form-control mb-4" placeholder="{{ _('New Password') }}" autocomplete="new-password">
 				<span class="password-strength-indicator indicator"></span>
 			</div>
 			<div class="form-group">
 				<input id="confirm_password" type="password"
-					class="form-control" placeholder="{{ _('Confirm Password') }}">
+					class="form-control" placeholder="{{ _('Confirm Password') }}" autocomplete="new-password">
 
 				<p class="password-mismatch-message text-muted small hidden mt-2"></p>
 			</div>